Why?

Make sure the code works

Why?

Make sure the code works

Still important, but not the main focus.

Why?

Become a better programmer

Code Review Structure

• Must – essesntial fixes
• Should – makes you a better developer (2-3 items)
• Could/Would – learning opportunities
  • Could – suggestion on different approach
  • Would – opinion on how the code reviewer might approach it differently

How Often?

Aim for once a week

How?

Preparing for the code review

Preparing for the code review

1. Find a piece of code to review

Work with the developer to find something they worked on

Preparing for the code review

2. Quick UI or functional test

Make sure it works and understand how it works

Preparing for the code review

3. Review the code looking for potential changes

Review aggregate changesets to cutdown on noiseKeep a list of all recommended changesShould take around an hour to review

Preparing for the code review

3. Summarize notes

Summarize the list into must, should, and could/would

How?

The code review

The code review

Should take around 15 minutes to discussExplain the thought process behind all the recommended changesPlan a follow up code review or pairing session if neededSend a written summary of the must, should, and could/would.

Summary

Code reviews once a week to become a better programmerPrepare beforehand by dividing recommendations into must, should, and could/would.Explain the reasoning behind the changesSend a written summary

Discussion

What do you think?